o-nikolas commented on code in PR #48849:
URL: https://github.com/apache/airflow/pull/48849#discussion_r2031637532
##########
airflow-core/src/airflow/provider_info.schema.json:
##########
@@ -32,7 +32,182 @@
"type": "string"
}
},
+ "integrations": {
+ "description": "Array of integrations provided by the provider.",
+ "type": "array",
+ "items": {
+ "type": "object",
+ "properties": {
+ "integration-name": {
+ "description": "Name of the integrations to expose by
the provider.",
+ "type": "string"
+ },
+ "external-doc-url": {
+ "description": "URL that describes the integration.",
Review Comment:
It seems only these first few description sentences are terminated with
periods, the rest are not.
```suggestion
"description": "Array of integrations provided by the provider",
"type": "array",
"items": {
"type": "object",
"properties": {
"integration-name": {
"description": "Name of the integrations to expose
by the provider",
"type": "string"
},
"external-doc-url": {
"description": "URL that describes the integration",
```
##########
airflow-core/src/airflow/provider_info.schema.json:
##########
@@ -32,7 +32,182 @@
"type": "string"
}
},
+ "integrations": {
+ "description": "Array of integrations provided by the provider.",
+ "type": "array",
+ "items": {
+ "type": "object",
+ "properties": {
+ "integration-name": {
+ "description": "Name of the integrations to expose by
the provider.",
+ "type": "string"
+ },
+ "external-doc-url": {
+ "description": "URL that describes the integration.",
+ "type": "string"
+ },
+ "logo": {
+ "description": "URL or path on the airflow side where
you can find the logo",
Review Comment:
```suggestion
"description": "URL or path on the airflow side
where you can find the logo",
```
##########
airflow-core/src/airflow/provider_info.schema.json:
##########
@@ -32,7 +32,182 @@
"type": "string"
}
},
+ "integrations": {
+ "description": "Array of integrations provided by the provider.",
+ "type": "array",
+ "items": {
+ "type": "object",
+ "properties": {
+ "integration-name": {
+ "description": "Name of the integrations to expose by
the provider.",
+ "type": "string"
+ },
+ "external-doc-url": {
+ "description": "URL that describes the integration.",
+ "type": "string"
+ },
+ "logo": {
+ "description": "URL or path on the airflow side where
you can find the logo",
+ "type": "string"
+ },
+ "tags": {
+ "description": "Tags describing the integration
(free-form)",
+ "type": "array",
+ "items": {
+ "type": "string"
+ }
+ }
+ }
+
+ }
+ },
+ "operators": {
+ "description": "List of operators provided by the integration",
+ "type": "array",
+ "items": {
+ "type": "object",
+ "properties": {
+ "integration-name": {
+ "description": "Name of the integration",
+ "type": "string"
+ },
+ "python-modules": {
+ "description": "List of modules where operators are
found",
+ "type" : "array",
+ "items": {
+ "type": "string"
+ }
+ }
+ }
+ }
+ },
+ "sensors": {
+ "description": "List of sensors provided by the integration",
+ "type": "array",
+ "items": {
+ "type": "object",
+ "properties": {
+ "integration-name": {
+ "description": "Name of the integration",
+ "type": "string"
+ },
+ "python-modules": {
+ "description": "List of modules where operators are
found",
+ "type" : "array",
+ "items": {
+ "type": "string"
+ }
+ }
+ }
+ }
+ },
+ "hooks": {
+ "description": "List of hooks provided by the integration",
+ "type": "array",
+ "items": {
+ "type": "object",
+ "properties": {
+ "integration-name": {
+ "description": "Name of the integration",
+ "type": "string"
+ },
+ "python-modules": {
+ "description": "List of modules where operators are
found",
Review Comment:
```suggestion
"description": "List of modules where the hooks are
found",
```
##########
airflow-core/src/airflow/provider_info.schema.json:
##########
@@ -32,7 +32,182 @@
"type": "string"
}
},
+ "integrations": {
+ "description": "Array of integrations provided by the provider.",
+ "type": "array",
+ "items": {
+ "type": "object",
+ "properties": {
+ "integration-name": {
+ "description": "Name of the integrations to expose by
the provider.",
+ "type": "string"
+ },
+ "external-doc-url": {
+ "description": "URL that describes the integration.",
+ "type": "string"
+ },
+ "logo": {
+ "description": "URL or path on the airflow side where
you can find the logo",
+ "type": "string"
+ },
+ "tags": {
+ "description": "Tags describing the integration
(free-form)",
+ "type": "array",
+ "items": {
+ "type": "string"
+ }
+ }
+ }
+
+ }
+ },
+ "operators": {
+ "description": "List of operators provided by the integration",
+ "type": "array",
+ "items": {
+ "type": "object",
+ "properties": {
+ "integration-name": {
+ "description": "Name of the integration",
+ "type": "string"
+ },
+ "python-modules": {
+ "description": "List of modules where operators are
found",
+ "type" : "array",
+ "items": {
+ "type": "string"
+ }
+ }
+ }
+ }
+ },
+ "sensors": {
+ "description": "List of sensors provided by the integration",
+ "type": "array",
+ "items": {
+ "type": "object",
+ "properties": {
+ "integration-name": {
+ "description": "Name of the integration",
+ "type": "string"
+ },
+ "python-modules": {
+ "description": "List of modules where operators are
found",
Review Comment:
```suggestion
"description": "List of modules where sensors are
found",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
