Lee-W commented on code in PR #48734:
URL: https://github.com/apache/airflow/pull/48734#discussion_r2038884648
##########
providers/oracle/tests/unit/oracle/hooks/test_oracle.py:
##########
@@ -256,6 +256,59 @@ def test_type_checking_thick_mode_config_dir(self):
with pytest.raises(TypeError, match=r"thick_mode_config_dir expected
str or None, got.*"):
self.db_hook.get_conn()
+ @pytest.mark.parametrize(
+ "connection_params, expected_uri",
+ [
+ pytest.param(
+ {"extra": '{"service_name": "schema"}', "schema": None,
"port": 1521},
+ "oracle://login:password@host:1521/schema",
Review Comment:
```suggestion
{"extra": '{"service_name": "service"}', "schema": None,
"port": 1521},
"oracle://login:password@host:1521/service",
```
nit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
