kaxil commented on code in PR #49128:
URL: https://github.com/apache/airflow/pull/49128#discussion_r2039758612
##########
task-sdk/src/airflow/sdk/execution_time/supervisor.py:
##########
@@ -650,7 +650,12 @@ def _service_subprocess(self, max_wait_time: float,
raise_on_timeout: bool = Fal
# If the subprocess writes "Hello, World!" to stdout:
# - `socket_handler` reads and processes the message.
# - If EOF is reached, the handler returns False to signal no more
reads are expected.
- need_more = socket_handler(key.fileobj)
+ # - BrokenPipeError should be caught and treated as if the handler
returned false, similar
+ # to EOF case
+ try:
+ need_more = socket_handler(key.fileobj)
+ except BrokenPipeError:
+ need_more = False
Review Comment:
We should the same for the following too then:
https://github.com/apache/airflow/blob/7defea9f6ad904273c6ff722f46c01c2208ad1d4/airflow-core/src/airflow/dag_processing/manager.py#L384-L388
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
