ephraimbuddy commented on code in PR #49097:
URL: https://github.com/apache/airflow/pull/49097#discussion_r2041167291
##########
airflow-core/src/airflow/models/dagrun.py:
##########
@@ -190,6 +190,15 @@ class DagRun(Base, LoggingMixin):
# Span context carrier, used for context propagation.
context_carrier = Column(MutableDict.as_mutable(ExtendedJSON))
span_status = Column(String(250), server_default=SpanStatus.NOT_STARTED,
nullable=False)
+ created_dag_version_id = Column(
Review Comment:
I think the many dag versions are handled at `dag_versions` method? You can
also see that the FK name is `dag_version_id_fkey`, should that also be named
`created_dag_version_id_fkey`? Just for consistency with our db designs, I
suggest we keep it as `dag_version_id`. Fwiw, TI.dag_version_id can also change
lots of time with non-versioned bundle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
