[
https://issues.apache.org/jira/browse/AIRFLOW-4574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16954434#comment-16954434
]
ASF GitHub Bot commented on AIRFLOW-4574:
-----------------------------------------
ashb commented on pull request #6163: [AIRFLOW-4574] SSHHook private_key may
only be supplied in extras
URL: https://github.com/apache/airflow/pull/6163
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add SSHHook private key parameter pkey
> --------------------------------------
>
> Key: AIRFLOW-4574
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4574
> Project: Apache Airflow
> Issue Type: Improvement
> Components: hooks
> Reporter: Freddy Fostvedt
> Assignee: Freddy Fostvedt
> Priority: Minor
> Fix For: 1.10.6
>
>
> The SSHHook only supports key_file parameter for specifying the path to a
> private key on disk. This means that private keys for connections that use
> ssh hooks must be stored on the disk of the worker instead of in the
> connection database. Maintaining the relationship between the worker's disk
> state and the connection makes deploying connection changes unnecessarily
> complicated.
> Paramiko, which SSHHook is built on, has support for accepting private keys
> as an input parameter (pkey)
> [https://github.com/paramiko/paramiko/blob/53095107625a1303bd9fcfcc7c2c20b9819ee79f/paramiko/client.py#L224]
> The work involved in doing this should only be to add pkey as a parameter to
> the SSHHook constructor, and test that SSHConnection passes pkey to SSHHook
> which then passes it to Paramiko.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
