bugraoz93 commented on code in PR #48914:
URL: https://github.com/apache/airflow/pull/48914#discussion_r2042834351


##########
.pre-commit-config.yaml:
##########
@@ -1357,6 +1357,13 @@ repos:
         pass_filenames: false
         files: ^airflow-core/src/airflow/api_fastapi/execution_api/.*\.py$
         require_serial: true
+      - id: generate-airflowctl-datamodels
+        name: Generate Datamodels for AirflowCTL
+        language: python
+        entry: uv run -p 3.12 --no-dev --no-progress --active --group codegen 
--project apache-airflow-ctl --directory airflow-ctl/ datamodel-codegen
+        pass_filenames: false
+        files: ^airflow-core/src/airflow/api_fastapi/core_api/.*\.py$
+        require_serial: true

Review Comment:
   Could you please add the same things for auth datamodels?
   ```suggestion
           require_serial: true
   - id: generate-airflowctl-auth-datamodels
           name: Generate Datamodels for AirflowCTL
           language: python
           entry: uv run -p 3.12 --no-dev --no-progress --active --group 
codegen --project apache-airflow-ctl --directory airflow-ctl/ datamodel-codegen 
--input=../airflow-core/src/airflow/api_fastapi/auth/managers/simple/openapi/v1-generated.yaml
 --output=src/airflowctl/api/datamodels/auth_generated.py
           pass_filenames: false
           files: 
^airflow-core/src/airflow/api_fastapi/auth/managers/simple/datamodels/.*\.py$
           require_serial: true
   ```



##########
.pre-commit-config.yaml:
##########
@@ -1357,6 +1357,13 @@ repos:
         pass_filenames: false
         files: ^airflow-core/src/airflow/api_fastapi/execution_api/.*\.py$
         require_serial: true
+      - id: generate-airflowctl-datamodels
+        name: Generate Datamodels for AirflowCTL
+        language: python
+        entry: uv run -p 3.12 --no-dev --no-progress --active --group codegen 
--project apache-airflow-ctl --directory airflow-ctl/ datamodel-codegen
+        pass_filenames: false
+        files: ^airflow-core/src/airflow/api_fastapi/core_api/.*\.py$

Review Comment:
   ```suggestion
           files: 
^airflow-core/src/airflow/api_fastapi/core_api/datamodels/.*\.py$
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to