eladkal commented on code in PR #49270:
URL: https://github.com/apache/airflow/pull/49270#discussion_r2043955626


##########
providers/git/src/airflow/providers/git/bundles/git.py:
##########
@@ -79,16 +80,20 @@ def __init__(
         )
 
         self._log.debug("bundle configured")
-        try:
-            self.hook = GitHook(git_conn_id=self.git_conn_id, 
repo_url=self.repo_url)
-            self.repo_url = self.hook.repo_url
-            self._log.debug("repo_url updated from hook", 
repo_url=self.repo_url)
-        except AirflowException as e:
-            self._log.warning("Could not create GitHook", 
conn_id=self.git_conn_id, exc=e)
+        self.hook: GitHook | None = None
+        if self.git_conn_id:
+            try:
+                self.hook = GitHook(git_conn_id=self.git_conn_id, 
repo_url=self.repo_url)
+            except AirflowException as e:
+                self._log.warning("Could not create GitHook", 
conn_id=self.git_conn_id, exc=e)
+            else:
+                self.repo_url = self.hook.repo_url
+                self._log.debug("repo_url updated from hook", 
repo_url=self.repo_url)

Review Comment:
   Regardless, why would you supply both if only one considered? This isn't a 
fallback case... Its a mutal exclusive case isn't it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to