ashb commented on code in PR #49097:
URL: https://github.com/apache/airflow/pull/49097#discussion_r2044147953
##########
airflow-core/tests/unit/api_fastapi/common/test_exceptions.py:
##########
@@ -186,23 +186,23 @@ def
test_handle_single_column_unique_constraint_error(self, session, table, expe
status_code=status.HTTP_409_CONFLICT,
detail={
"reason": "Unique constraint violation",
- "statement": "INSERT INTO dag_run (dag_id,
queued_at, logical_date, start_date, end_date, state, run_id, creating_job_id,
run_type, triggered_by, conf, data_interval_start, data_interval_end,
run_after, last_scheduling_decision, log_template_id, updated_at, clear_number,
backfill_id, bundle_version, scheduled_by_job_id, context_carrier) VALUES (?,
?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, (SELECT max(log_template.id) AS max_1
\nFROM log_template), ?, ?, ?, ?, ?, ?)",
+ "statement": "INSERT INTO dag_run (dag_id,
queued_at, logical_date, start_date, end_date, state, run_id, creating_job_id,
run_type, triggered_by, conf, data_interval_start, data_interval_end,
run_after, last_scheduling_decision, log_template_id, updated_at, clear_number,
backfill_id, bundle_version, scheduled_by_job_id, context_carrier,
created_dag_version_id) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?,
(SELECT max(log_template.id) AS max_1 \nFROM log_template), ?, ?, ?, ?, ?, ?,
?)",
Review Comment:
o_O I feel nervous about returning the query in the Error response!
(Not a problem with this PR, but I don't like it)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
