Re: [PR] feature(ui): Make entire task box clickable to select the task in Air… [airflow]

Tue, 15 Apr 2025 09:19:28 -0700 


jsjasonseba commented on PR #49299:
URL: https://github.com/apache/airflow/pull/49299#issuecomment-2806270443

   > Generally we shouldn't have too much stuff inside of an `<a>` tag. Which, 
we should change our use of `TaskLink` here so we don't have two links.
   > 
   > <img alt="Screenshot 2025-04-15 at 11 25 17 AM" width="793" 
src="https://private-user-images.githubusercontent.com/4600967/433915372-e1e3ca20-54f6-4387-b21f-118a3958d336.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDQ3MzExMzcsIm5iZiI6MTc0NDczMDgzNywicGF0aCI6Ii80NjAwOTY3LzQzMzkxNTM3Mi1lMWUzY2EyMC01NGY2LTQzODctYjIxZi0xMThhMzk1OGQzMzYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDQxNSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTA0MTVUMTUyNzE3WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9N2JiNWRkMzk4M2VlNWJjNjg2MTk0NTE0NmY0ZDc1NDZiNWQ4OGFiM2I0NDVhY2Q3MGFmODI3MDA5NTFjMTU0MiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.vH0m-YOZMA60AN-1OZx8ljeVCuQf7XLrUzGlwPbDPk0";>
   > Also, let's update the other node components for a consistent UX.
   
   Hi @bbovenzi , I added a flag in TaskLink to disable the router link when 
defined by TaskNode. I think I missed a case, where do you find this error?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to