guan404ming commented on PR #49165: URL: https://github.com/apache/airflow/pull/49165#issuecomment-2805050643
Thanks for the review! I found the lint error: I'd accidentally updated `typescript-eslint`. Reverting fixed it, matching the CI results. Investigating this revealed a potential issue with the `populatedStandardFields.schema` type. Trying `??=` caused a `[@typescript-eslint/no-unnecessary-condition]` error, as the current types indicate `schema` should always be `undefined`. So, my current fix uses direct assignment. However, using `??=` might be more robust if the type definition isn't 100% accurate (it would preserve an existing value instead of overwriting). But I'm not sure that to stick with direct assignment, or to switch to `??=` would be better. Do you have any preference? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
