jsjasonseba commented on code in PR #49361:
URL: https://github.com/apache/airflow/pull/49361#discussion_r2049248884
##########
airflow-core/src/airflow/ui/src/queries/useDags.tsx:
##########
@@ -42,16 +42,15 @@ export const useDags = (
const refetchInterval = useAutoRefresh({});
- const { orderBy, ...runsParams } = searchParams;
const {
data: runsData,
error: runsError,
isFetching: isRunsFetching,
isLoading: isRunsLoading,
} = useDagsServiceRecentDagRuns(
{
- ...runsParams,
- dagRunsLimit: 14,
+ ...searchParams,
+ dagRunsLimit: 1,
Review Comment:
I've been thinking again about doing the pagination on DagModel first before
joining to get recent DAG runs. However, this ends up duplicating the logic of
the `dags` endpoint from the public API
At this point, it might make more sense to create a separate DAGs list
endpoint specifically for the UI, with recent DAG runs already pre-joined,
separating concerns from the public API.
Let me know what you think @pierrejeambrun @bbovenzi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
