This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new bfc567f4e6c Use unused pytest params in standard provider tests
(#49422)
bfc567f4e6c is described below
commit bfc567f4e6c0bd3cd0868f75149d4420293016d7
Author: GPK <[email protected]>
AuthorDate: Fri Apr 18 13:06:07 2025 +0100
Use unused pytest params in standard provider tests (#49422)
---
.../unit/standard/decorators/test_python_virtualenv.py | 2 +-
.../tests/unit/standard/decorators/test_sensor.py | 2 +-
.../tests/unit/standard/hooks/test_subprocess.py | 2 ++
.../tests/unit/standard/operators/test_python.py | 18 +++++++++++++++---
4 files changed, 19 insertions(+), 5 deletions(-)
diff --git
a/providers/standard/tests/unit/standard/decorators/test_python_virtualenv.py
b/providers/standard/tests/unit/standard/decorators/test_python_virtualenv.py
index caf438a04d1..f67fa6a9475 100644
---
a/providers/standard/tests/unit/standard/decorators/test_python_virtualenv.py
+++
b/providers/standard/tests/unit/standard/decorators/test_python_virtualenv.py
@@ -232,7 +232,7 @@ class TestPythonVirtualenvDecorator:
],
)
def test_fail(self, serializer, dag_maker):
- @task.virtualenv()
+ @task.virtualenv(serializer=serializer)
def f():
raise Exception
diff --git a/providers/standard/tests/unit/standard/decorators/test_sensor.py
b/providers/standard/tests/unit/standard/decorators/test_sensor.py
index e4db8078588..ffdf49b8122 100644
--- a/providers/standard/tests/unit/standard/decorators/test_sensor.py
+++ b/providers/standard/tests/unit/standard/decorators/test_sensor.py
@@ -35,7 +35,7 @@ pytestmark = pytest.mark.db_test
reason="Decorators were part of core not providers, so this test doesnt
make sense for < AF3.",
)
class TestSensorDecorator:
- def test_sensor_fails_on_none_python_callable(self, dag_maker):
+ def test_sensor_fails_on_none_python_callable(self):
not_callable = {}
with pytest.raises(TypeError):
task.sensor(not_callable)
diff --git a/providers/standard/tests/unit/standard/hooks/test_subprocess.py
b/providers/standard/tests/unit/standard/hooks/test_subprocess.py
index 2b2e9473359..d0833c85823 100644
--- a/providers/standard/tests/unit/standard/hooks/test_subprocess.py
+++ b/providers/standard/tests/unit/standard/hooks/test_subprocess.py
@@ -92,6 +92,7 @@ class TestSubprocessHook:
hook = SubprocessHook()
hook.run_command(command=["bash", "-c", 'echo "stdout"'])
+ mock_temporary_directory.assert_called_once()
mock_popen.assert_called_once_with(
["bash", "-c", 'echo "stdout"'],
cwd="/tmp/airflowtmpcatcat",
@@ -113,4 +114,5 @@ class TestSubprocessHook:
hook = SubprocessHook()
hook.sub_process = MagicMock()
hook.send_sigterm()
+ mock_getpgid.assert_called_once()
mock_killpg.assert_called_with(123, signal.SIGTERM)
diff --git a/providers/standard/tests/unit/standard/operators/test_python.py
b/providers/standard/tests/unit/standard/operators/test_python.py
index ef84c0dda3d..4206db5481b 100644
--- a/providers/standard/tests/unit/standard/operators/test_python.py
+++ b/providers/standard/tests/unit/standard/operators/test_python.py
@@ -1155,7 +1155,9 @@ class
TestPythonVirtualenvOperator(BaseTestPythonVirtualenvOperator):
return True
raise RuntimeError
- self.run_as_task(f, system_site_packages=False,
requirements=extra_requirements)
+ self.run_as_task(
+ f, system_site_packages=False, requirements=extra_requirements,
serializer=serializer
+ )
def test_system_site_packages(self):
def f():
@@ -1201,7 +1203,12 @@ class
TestPythonVirtualenvOperator(BaseTestPythonVirtualenvOperator):
def f():
import funcsigs # noqa: F401
- self.run_as_task(f, requirements=["funcsigs", *extra_requirements],
system_site_packages=False)
+ self.run_as_task(
+ f,
+ requirements=["funcsigs", *extra_requirements],
+ system_site_packages=False,
+ serializer=serializer,
+ )
@pytest.mark.parametrize(
"serializer, extra_requirements",
@@ -1216,7 +1223,12 @@ class
TestPythonVirtualenvOperator(BaseTestPythonVirtualenvOperator):
def f():
import funcsigs # noqa: F401
- self.run_as_task(f, requirements=["funcsigs>1.0",
*extra_requirements], system_site_packages=False)
+ self.run_as_task(
+ f,
+ requirements=["funcsigs>1.0", *extra_requirements],
+ system_site_packages=False,
+ serializer=serializer,
+ )
def test_requirements_file(self):
def f():
