bugraoz93 commented on PR #49449: URL: https://github.com/apache/airflow/pull/49449#issuecomment-2816693491
> I just realised, @eladkal this could be a breaking change , the method is public facing interface, WDYT ? should i revert and add mypy ignore check. > > Ideally the `get_oauth_token` is being added in `SnowflakeHook`, so we dont need this method in `SnowflakeSqlApiHook`, this can be inherited from `SnowflakeHook` I agree that it was recently added to `SnowflakeHook`. We can deprecate the method first and call from `SnowflakeHook` to give a deprecation warning for direct usage. Do you think we need to add a news fragment for this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
