gopidesupavan commented on code in PR #49482:
URL: https://github.com/apache/airflow/pull/49482#discussion_r2052264699
##########
providers/snowflake/src/airflow/providers/snowflake/hooks/snowflake.py:
##########
@@ -187,16 +187,22 @@ def _get_field(self, extra_dict, field_name):
return extra_dict[field_name] or None
return extra_dict.get(backcompat_key) or None
- def get_oauth_token(self, conn_config: dict) -> str:
+ def get_oauth_token(self, conn_config: dict | None = None) -> str:
"""Generate temporary OAuth access token using refresh token in
connection details."""
- url =
f"https://{conn_config['account']}.snowflakecomputing.com/oauth/token-request"
+ if conn_config is None:
+ conn_config = self._get_conn_params
+
+ def generate_url():
+ region = f"{conn_config['region']}" if conn_config.get("region")
else ""
+ return
f"https://{conn_config['account']}.{region}.snowflakecomputing.com/oauth/token-request"
Review Comment:
Yes agree, @bugraoz93 look at the `def account_identifier` method it handle
region. we should use that similarly or moving that method to Hook also works ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
