[jira] [Commented] (AIRFLOW-5658) Links issue through reverse proxy access

[ASF GitHub Bot (Jira)]

    [ 
https://issues.apache.org/jira/browse/AIRFLOW-5658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16955257#comment-16955257
 ] 

ASF GitHub Bot commented on AIRFLOW-5658:
-----------------------------------------

osule commented on pull request #6374: [AIRFLOW-5658] Fix broken links when 
running behind reverse proxy
URL: https://github.com/apache/airflow/pull/6374
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow 
Jira](https://issues.apache.org/jira/browse/AIRFLOW/5658) issues and references 
them in the PR title. 
     - https://issues.apache.org/jira/browse/AIRFLOW-5658
     - ~In case you are fixing a typo in the documentation you can prepend your 
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.~
     - ~In case you are proposing a fundamental code change, you need to create 
an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).~
     - ~In case you are adding a dependency, check if the license complies with 
the [ASF 3rd Party License 
Policy](https://www.apache.org/legal/resolved.html#category-x).~
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI 
changes:
   
   This fixes broken links to Configurations and Versions page when running 
Airflow behind reverse proxy.
   
   Also, broken display of Task tries icon is also remedied.
   
   __Before__
   <img width="1270" alt="image" 
src="https://user-images.githubusercontent.com/13223818/67150097-a272a180-f2b3-11e9-83b6-a8f5a3000b8c.png";>
   
   
   __After__
   <img width="1274" alt="image" 
src="https://user-images.githubusercontent.com/13223818/67150078-62abba00-f2b3-11e9-9955-8c5bacf008a7.png";>
   
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason: No fundamental changes to code.
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] ~In case of new functionality, my PR adds documentation that describes 
how to use it.~
     - ~All the public functions and the classes in the PR contain docstrings 
that explain what it does~
     - ~If you implement backwards incompatible changes, please leave a note in 
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so 
we can assign it to a appropriate release~
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Links issue through reverse proxy access 
> -----------------------------------------
>
>                 Key: AIRFLOW-5658
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5658
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: ui
>    Affects Versions: 1.10.4, 1.10.5
>            Reporter: Mikołaj Morawski
>            Assignee: Oluwafemi Sule
>            Priority: Trivial
>         Attachments: image-2019-10-15-16-02-45-731.png
>
>
> The access through a reverse proxy is not working for the following two uris:
> /configuration
> /version
>  
> I think that the root cause is here:
> [https://github.com/apache/airflow/blob/master/airflow/www/app.py]
> {code:java}
>             appbuilder.add_link("Configurations",
>                                 href='/configuration',
>                                 category="Admin",
>                                 category_icon="fa-user")
>             appbuilder.add_link('Version',
>                                 href='/version',
>                                 category='About',
>                                 category_icon='fa-th')
> {code}
>  the "href" parameter does not use the "views" reference here. The add_link 
> should not be used for this reference.  
>  
>  The second problem is that the "Task Tries" icon is not displayed properly. 
>   !image-2019-10-15-16-02-45-731.png!
> Regards,
> Mikolaj 
>  
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)