uranusjr commented on code in PR #48567:
URL: https://github.com/apache/airflow/pull/48567#discussion_r2053380008


##########
task-sdk/src/airflow/sdk/__init__.py:
##########
@@ -44,9 +46,11 @@
     "chain_linear",
     "cross_downstream",
     "dag",
+    "dataset",

Review Comment:
   `dataset` and `model` do not even exist, from what I can tell, so they 
should be removed.
   
   The import path we deprecated is in core (`airflow.datasets`) and these are 
different things. I don’t particularly like the idea of exposing them in 
`airflow.sdk` though; they are more like operator subclasses, and we don’t do 
the same for operators.
   
   Thinking about this more, maybe these should exist in the standard provider 
instead?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to