rawwar commented on code in PR #49282:
URL: https://github.com/apache/airflow/pull/49282#discussion_r2053384099
##########
providers/common/sql/tests/unit/common/sql/operators/test_sql.py:
##########
@@ -190,6 +195,23 @@ def test_output_processor(self, mock_get_db_hook):
assert descriptions == ("id", "name")
assert result == [(1, "Alice"), (2, "Bob")]
+ @skip_if_force_lowest_dependencies_marker
+ def test_sql_operator_extra_dejson_fields_to_hook_params(self):
+ with mock.patch(
+
"airflow.providers.common.sql.operators.sql.BaseHook.get_connection",
+ return_value=Connection(conn_id="sql_default",
conn_type="postgres"),
+ ) as mock_get_conn:
+ mock_get_conn.return_value = Connection(
+ conn_id="google_cloud_bigquery_default",
+ conn_type="gcpbigquery",
+ extra={"use_legacy_sql": False, "priority": "INTERACTIVE"},
+ )
+ self._operator.hook_params = {"use_legacy_sql": True, "location":
"us-east1"}
+ assert self._operator._hook.conn_type == "gcpbigquery"
+ assert self._operator._hook.use_legacy_sql
Review Comment:
```suggestion
assert self._operator._hook.use_legacy_sql is True
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
