vincbeck commented on code in PR #49492: URL: https://github.com/apache/airflow/pull/49492#discussion_r2054222781
########## providers/fab/docs/auth-manager/index.rst: ########## @@ -30,6 +30,7 @@ Follow the below topics as well to understand other aspects of FAB auth manager: * :doc:`access-control`. How FAB auth manager manage users and permissions * :doc:`webserver-authentication`. To learn the different options available in FAB auth manager to authenticate users * :doc:`security`. To learn the different options available in FAB auth manager to secure the UI provided by FAB auth manager +* :doc:`configuring-flask-app`. To learn the configuration options available for the flask app for Airflow webserver. Review Comment: ```suggestion * :doc:`configuring-flask-app`. To learn the configuration options available for the flask app used by ``FabAuthManager``. ``` ########## providers/fab/docs/auth-manager/configuring-flask-app.rst: ########## @@ -0,0 +1,39 @@ + .. Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + .. http://www.apache.org/licenses/LICENSE-2.0 + + .. Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + +Configuring Flask Application for Airflow Webserver +=================================================== + +Airflow uses Flask to render the web UI. When you initialize the Airflow webserver, predefined configuration +is used, based on the ``webserver`` section of the ``airflow.cfg`` file. You can override these settings Review Comment: I dont think we should have "AF2 vs AF2 comparison" in docs. ```suggestion ``FabAuthManager`` and Airflow 2 plugins uses Flask to render the web UI.When initialized, predefined configuration is used, based on the ``webserver`` section of the ``airflow.cfg`` file. You can override these settings ``` ########## providers/fab/docs/auth-manager/configuring-flask-app.rst: ########## @@ -0,0 +1,39 @@ + .. Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + .. http://www.apache.org/licenses/LICENSE-2.0 + + .. Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + +Configuring Flask Application for Airflow Webserver +=================================================== + +Airflow uses Flask to render the web UI. When you initialize the Airflow webserver, predefined configuration +is used, based on the ``webserver`` section of the ``airflow.cfg`` file. You can override these settings +and add any extra settings however by adding flask configuration to ``webserver_config.py`` file in your +``$AIRFLOW_HOME`` directory. This file is automatically loaded by the webserver. Review Comment: ```suggestion and add any extra settings by adding flask configuration to ``webserver_config.py`` file specified in ``[fab] config_file`` (by default it is ``$AIRFLOW_HOME/webserver_config.py``). This file is automatically loaded by the webserver. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
