paolofacchinetti commented on code in PR #49727:
URL: https://github.com/apache/airflow/pull/49727#discussion_r2058714652
##########
chart/templates/api-server/api-server-ingress.yaml:
##########
@@ -0,0 +1,113 @@
+{{/*
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+*/}}
+
+################################
+## Airflow API Server Ingress
+#################################
+{{- if semverCompare ">=3.0.0" .Values.airflowVersion }}
+{{- if or .Values.ingress.web.enabled .Values.ingress.enabled }}
Review Comment:
I guess I can duplicate `ingress.web` into `ingress.apiserver` and have the
new ingress fetch configs from that. I assume eventually `ingress.web` and the
entire webserver templates will be removed from the chart, so `ingress.web`
will have to go too
also i talked about breaking changes in my last comment, but it already
isn't working right now with chart 1.16.0, so i dont think the change is a big
deal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
