yunchipang commented on code in PR #49601: URL: https://github.com/apache/airflow/pull/49601#discussion_r2059434505
########## airflow-ctl/tests/airflow_ctl/ctl/commands/test_config_command.py: ########## @@ -0,0 +1,78 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +import contextlib +from io import StringIO + +from airflowctl.api.client import ClientKind +from airflowctl.ctl import cli_parser +from airflowctl.ctl.commands import config_command + + +class TestCliConfigGetValue: + @classmethod + def setup_class(cls): + cls.parser = cli_parser.get_parser() + + def test_should_display_value(self, api_client_maker): + api_client = api_client_maker( + path="/api/v2/config/section/core/option/test_key", + # sample response: sections=[ConfigSection(name='core', options=[ConfigOption(key='dags_folder', value='/files/dags')])] + response_json={ + "sections": [{"name": "core", "options": [{"key": "test_key", "value": "test_value"}]}] + }, + expected_http_status_code=200, + kind=ClientKind.CLI, + ) + + args = self.parser.parse_args(["config", "get-value", "--section", "core", "--option", "test_key"]) + + with contextlib.redirect_stdout(StringIO()) as temp_stdout: + config_command.get_value(args, api_client=api_client) + + assert temp_stdout.getvalue().strip() == "test_value" + + def test_should_not_raise_exception_when_section_for_config_with_value_defined_elsewhere_is_missing( Review Comment: @bugraoz93 I was copying the logic in `airflow-core/tests/unit/cli/commands/test_config_command.py`, however I was not quite understanding it. Especially the difference between `test_should_not_raise_exception_when_section_for_config_with_value_defined_elsewhere_is_missing` and `test_should_raise_exception_when_option_is_missing`. The API client raises 404 for both cases, then why are they handled differently? Could you kindly clarify? Thanks a lot! The test class passes for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
