potiuk commented on PR #49339:
URL: https://github.com/apache/airflow/pull/49339#issuecomment-2834131759
Ah..... and one other nice optmisation now that you are looking at that.
Actually we should do the same in the main `pyproject.toml` in
"optional-dependencies". Instead of having this:
```
"pandas" = [
# In pandas 2.2 minimal version of the sqlalchemy is 2.0
#
https://pandas.pydata.org/docs/whatsnew/v2.2.0.html#increased-minimum-versions-for-dependencies
# However Airflow not fully supports it yet:
https://github.com/apache/airflow/issues/28723
"pandas>=2.1.2,<2.3",
]
"polars" = [
"polars>=1.26.0",
]
```
We shoudl have this:
```
"pandas" = [
"apache-airflow-providers-common-sql[pandas]",
]
"polars" = [
"apache-airflow-providers-common-sql[polars]",
]
```
This has two benefits:
* more DRY
* future-compatible (if we increase lower-bound polars / pandas in the
future common-sql, it will be used from there when installing
`apache-airflow[pandas,polars]`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
