Crowiant opened a new pull request, #49899:
URL: https://github.com/apache/airflow/pull/49899
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
The problem with failing KubernetesJobOperator when using the parallelism
option starts to appear from version 8.4.1, according to apache#44994.
Reason: As KubernetesJobOperator inherits from KubernetesPodOperator, it
also uses some of the parent methods.
One of these, get_or_create_pod, is set to find only one or no pod during
execution. In case the method finds two pods, it raises the exception 'More
than one pod found'. While this is appropriate for the KubernetesPodOperator
logic, KubernetesJobOperator could use more than one pod during execution.
That's why in this PR a new method, get_pods, was added. It will be more
suitable for the logic of this operator. Also, a new attribute, self.pods, has
been introduced in the operator. This attribute is needed for handling the
logic of the do_xcom_push and get_logs flags.
Change KubernetesJobTrigger to handle KubernetesJobOperator with parallelism
and deferrable flag.
Change GKEStartJobOperator.execute_deferrable to handle multiple pods.
Change GKEJobTrigger to handle multiple pods.
Adjust system test example_kubernetes_engine_job.py in google provider to
reflect changes.
Adjust and add unit tests in providers: cncf/kubernetes, google
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
