o-nikolas commented on PR #49433: URL: https://github.com/apache/airflow/pull/49433#issuecomment-2836733192
Sorry folks I've been out sick since Wednesday! Glad you did a deep dive @kaxil and you are now convinced :grinning: I was absolutely certain it was not needed for Airflow Executor workflow, which I've worked quite a bit on! @ihnokim > could you please confirm if this approach makes sense? > > Remove executor-related environment variables from the default K8s pod template and example files. I still think Airflow configuration should be as consistent as possible across all nodes/workers/pods executing it, personally. But happy to commit if I'm out voted on that. > Resolve the mismatch issue where the UI displays a command that differs from the actual one executed by the pod. > Address the validation failure caused by the executor in tasks running on worker pods. To me the code is nice and simple as is, with no branching logic, and we also get one last check that we're not launching a task for which there is no executor configured to take it, which is a critical piece of multi exec config (so tasks don't get stranded in scheduled state). As long as the config is the same (as we expect) everything functions correctly. Which to me is the real fix, But again, happy to commit if I'm out voted on that one. > Add appropriate tests. > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
