potiuk commented on code in PR #49922:
URL: https://github.com/apache/airflow/pull/49922#discussion_r2065944683
##########
dev/breeze/src/airflow_breeze/commands/testing_commands.py:
##########
@@ -1010,6 +1017,13 @@ def system_tests(
python: str,
skip_docker_compose_down: bool,
test_timeout: int,
+ use_airflow_version: str,
+ airflow_constraints_reference: str,
+ clean_airflow_installation: bool,
+ force_lowest_dependencies: bool,
+ install_airflow_with_constraints: bool,
+ distribution_format: str,
+ use_distributions_from_dist: bool,
Review Comment:
It makes sense to cover existing functionality - but yes - all those params
should be passed-through to `ShellParams` as they might be used for various
cases - for example we could build CI image for tests in `v3-0-test` -there we
just pull packages from PyPI rather than build CI images locally etc. etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
