jedcunningham opened a new pull request, #46877:
URL: https://github.com/apache/airflow/pull/46877
With gitsync, the DAGs folder is a symlink, `repo -> {commit}`. In our DAG
processor, when we clean up stale DAGs, we [compare processor_subdir
here](https://github.com/apache/airflow/blob/223b0a4b61a44a83895371b2c9a3a5cafa5df8ea/airflow/models/dag.py#L4055)
to make sure we are only cleaning up "our" DAG files - but the db record has
the resolved path, not the one with the symlink because we resolve it
[here](https://github.com/apache/airflow/blob/223b0a4b61a44a83895371b2c9a3a5cafa5df8ea/airflow/dag_processing/manager.py#L1093).
I don't think we really need the resolved path - the one that matches the
dags_folder config is better for us generally.
Fair warning, there is some history of bugs in this area, see #41433,
#42111, but I believe this change is right and won't have any negative side
effects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
