Lee-W commented on code in PR #49779:
URL: https://github.com/apache/airflow/pull/49779#discussion_r2067949467
##########
airflow-core/newsfragments/49779.significant.rst:
##########
@@ -0,0 +1,20 @@
+SecretCache class has been moved to ``airflow.sdk.execution_time.cache``
+
+* Types of change
+
+ * [ ] Dag changes
+ * [ ] Config changes
+ * [ ] API changes
+ * [ ] CLI changes
+ * [ ] Behaviour changes
+ * [ ] Plugin changes
+ * [ ] Dependency changes
+ * [x] Code interface changes
+
+* Migration rules needed
+
+ * ruff
+
+ * AIR302
+
+ * [x] ``airflow.secrets.cache`` → ``airflow.sdk.execution_time.cache``
Review Comment:
If that's the case, we probably should't mark it as AIR301, this will need
some discussion
##########
airflow-core/newsfragments/49779.significant.rst:
##########
@@ -0,0 +1,20 @@
+SecretCache class has been moved to ``airflow.sdk.execution_time.cache``
+
+* Types of change
+
+ * [ ] Dag changes
+ * [ ] Config changes
+ * [ ] API changes
+ * [ ] CLI changes
+ * [ ] Behaviour changes
+ * [ ] Plugin changes
+ * [ ] Dependency changes
+ * [x] Code interface changes
+
+* Migration rules needed
+
+ * ruff
+
+ * AIR302
+
+ * [x] ``airflow.secrets.cache`` → ``airflow.sdk.execution_time.cache``
Review Comment:
```suggestion
* [x] ``airflow.secrets.cache.SecretCache`` →
``airflow.sdk.execution_time.cache.SecretCache``
```
##########
airflow-core/newsfragments/49779.significant.rst:
##########
@@ -0,0 +1,20 @@
+SecretCache class has been moved to ``airflow.sdk.execution_time.cache``
+
+* Types of change
+
+ * [ ] Dag changes
+ * [ ] Config changes
+ * [ ] API changes
+ * [ ] CLI changes
+ * [ ] Behaviour changes
+ * [ ] Plugin changes
+ * [ ] Dependency changes
+ * [x] Code interface changes
+
+* Migration rules needed
+
+ * ruff
+
+ * AIR302
+
+ * [x] ``airflow.secrets.cache`` → ``airflow.sdk.execution_time.cache``
Review Comment:
I guess that's SecretCache only
##########
airflow-core/newsfragments/49779.significant.rst:
##########
@@ -0,0 +1,20 @@
+SecretCache class has been moved to ``airflow.sdk.execution_time.cache``
+
+* Types of change
+
+ * [ ] Dag changes
+ * [ ] Config changes
+ * [ ] API changes
+ * [ ] CLI changes
+ * [ ] Behaviour changes
+ * [ ] Plugin changes
+ * [ ] Dependency changes
+ * [x] Code interface changes
+
+* Migration rules needed
+
+ * ruff
+
+ * AIR302
+
+ * [x] ``airflow.secrets.cache`` → ``airflow.sdk.execution_time.cache``
Review Comment:
Also, after a second thought, this (`airflow.secrets.cache.SecretCache`) is
working in 3.0.0 but not in 3.0.1 and above?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
