kaxil commented on code in PR #45914:
URL: https://github.com/apache/airflow/pull/45914#discussion_r2069328277
##########
airflow/utils/serve_logs.py:
##########
@@ -133,7 +133,7 @@ def validate_pre_signed_url():
@flask_app.route("/log/<path:filename>")
def serve_logs_view(filename):
- return send_from_directory(log_directory, filename,
mimetype="application/json", as_attachment=False)
+ return send_from_directory(log_directory, filename,
mimetype="text/plain", as_attachment=False)
Review Comment:
Same here -- concerned about backwards compatibility, while this should be
an internal only change, it could break any clients expecting JSON response
from endpoint. I want to ensure we don't introduce any regression in 2.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
