guan404ming commented on code in PR #49535:
URL: https://github.com/apache/airflow/pull/49535#discussion_r2069931136
##########
airflow-core/docs/authoring-and-scheduling/deferring.rst:
##########
@@ -460,6 +460,40 @@ In the above example, the trigger will end the task
instance directly if ``end_f
Exiting from the trigger works only when listeners are not integrated for
the deferrable operator. Currently, when deferrable operator has the
``end_from_trigger`` attribute set to ``True`` and listeners are integrated it
raises an exception during parsing to indicate this limitation. While writing
the custom trigger, ensure that the trigger is not set to end the task instance
directly if the listeners are added from plugins. If the ``end_from_trigger``
attribute is changed to different attribute by author of trigger, the DAG
parsing would not raise any exception and the listeners dependent on this task
would not work. This limitation will be addressed in future releases.
+Pushing XComs from Deferred Tasks
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+.. versionadded:: 2.10.0
Review Comment:
Sorry for the late. It took some time to deal with this. And I think this
func is not supported for all triggers before 2.10.0 since there are not
implementation of some thing like `self.xcoms` or something like the example do.
I only see the trigger test which use the functionality the example show
https://github.com/apache/airflow/blob/c37e6eb482548d913d71c3ac023b7d74c05d5b5e/airflow-core/tests/unit/models/test_trigger.py#L202-L211
please let me know if there is anything I could help
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
