vincbeck commented on code in PR #50057:
URL: https://github.com/apache/airflow/pull/50057#discussion_r2070093942
##########
airflow-core/docs/authoring-and-scheduling/connections.rst:
##########
@@ -47,5 +47,5 @@ Airflow allows to define custom connection types. This is
what is described in d
:doc:`apache-airflow-providers:index` - providers give you the capability of
defining your own connections.
The connection customization can be done by any provider, but also
many of the providers managed by the community define custom connection types.
-The full list of all providers delivered by ``Apache Airflow community managed
providers`` can be found in
+The full list of all connections delivered by ``Apache Airflow community
managed providers`` can be found in
Review Comment:
Let's keep it, it is fine 👌
##########
providers/amazon/tests/unit/amazon/aws/triggers/test_sqs.py:
##########
@@ -37,9 +37,12 @@
TEST_BOTOCORE_CONFIG = {"region_name": "us-east-1"}
[email protected](not AIRFLOW_V_3_0_PLUS, reason="Requires Airflow 3.0.+")
Review Comment:
Why do we need to skip this test? `SqsSensorTrigger` (I mean using directly
the trigger and not through the common messaging) should work in AF2
##########
devel-common/src/sphinx_exts/operators_and_hooks_ref.py:
##########
@@ -481,6 +481,17 @@ def render_content(
)
+class QueuesDirective(BaseJinjaReferenceDirective):
+ """Generate list of queues"""
+
+ def render_content(
+ self, *, tags: set[str] | None, header_separator: str =
DEFAULT_HEADER_SEPARATOR
+ ) -> str:
+ return _common_render_list_content(
+ header_separator=header_separator, resource_type="queues",
template="queues.rst.jinja2"
+ )
+
+
Review Comment:
I did not know we could do that! Super cool!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
