jscheffl commented on code in PR #49981:
URL: https://github.com/apache/airflow/pull/49981#discussion_r2070319643
##########
airflow-core/src/airflow/ui/src/components/FlexibleForm/FlexibleForm.tsx:
##########
@@ -64,7 +92,12 @@ export const FlexibleForm = ({ flexibleFormDefaultSection,
initialParamsDict }:
processedSections.set(currentSection, true);
return (
- <Accordion.Item key={currentSection} value={currentSection}>
+ <Accordion.Item
+ borderColor={sectionError.get(currentSection) ? "red" :
undefined}
+ borderStyle="solid"
+ key={currentSection}
+ value={currentSection}
+ >
<Accordion.ItemTrigger
cursor="button">{currentSection}</Accordion.ItemTrigger>
Review Comment:
You added the text coloring now - I am not fully sure - is it sufficient for
users to understand that "red color" just means error and is it intuitive
enough to understand that the section needs to be opened? Or should we add some
kind of validation text marker?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
