vincbeck commented on code in PR #50093:
URL: https://github.com/apache/airflow/pull/50093#discussion_r2070769367
##########
airflow-core/src/airflow/models/deadline.py:
##########
@@ -90,3 +96,77 @@ def _determine_resource() -> tuple[str, str]:
def add_deadline(cls, deadline: Deadline, session: Session = NEW_SESSION):
"""Add the provided deadline to the table."""
session.add(deadline)
+
+
+class DeadlineTrigger(Enum):
Review Comment:
I am pretty sure we already had this conversation but I cannot remember
where we settled. I find the term `DeadlineTrigger` confusing because `trigger`
is already used in Airflow and can confuse users/developers. I would rather
chose another term (I do not a proposal right now but i can comes later :)).
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
