bugraoz93 commented on issue #49019: URL: https://github.com/apache/airflow/issues/49019#issuecomment-2847992094
> [@bugraoz93](https://github.com/bugraoz93) Sorry for late > > I'm not sure what the best approach is for ensuring that list operations return all results. Should I use a conditional choice or generate a new function regarding `QueryLimit` parameter to return all results? Since [here](https://github.com/apache/airflow/pull/49243) the limit has been reduced from 100 to 50. Could you help me determine What's the better choice to return all entries > > I am sorry for the delay and will make sure it doesn’t happen again. I'll do my best to raise a PR in a today or tomorrow I think the best approach is to utilise all `list` operations under `airflow-ctl/src/airflowctl/api/opreations.py` such as connections, pools, variables, etc, and make use of API endpoint parameters to get all. See offset and limit, we already have pagination in the endpoints. We should follow a similar approach with the UI on the logic side using pagination in the `airflowctl operations`. API example: https://github.com/apache/airflow/blob/a447474738413c29403413d33990b5af8413543d/airflow-core/src/airflow/api_fastapi/core_api/routes/public/connections.py#L108-L121 UI example: https://github.com/apache/airflow/blob/a447474738413c29403413d33990b5af8413543d/airflow-core/src/airflow/ui/src/pages/Connections/Connections.tsx#L101-L106 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
