potiuk opened a new pull request, #50180:
URL: https://github.com/apache/airflow/pull/50180
…0176)
So far, when we built release images in CI or locally we relied on either
the emulation or having a builder configured that could handle having docker
engines running at the same time on different hardware.
That had some disadvantages:
* for emulation, it was terribly slow.It was 10/15 times slower than
building appropriate platform on appropriate hardware - making our image relase
process taking more than hour. Also build output from both runs was interleaved
which made it rather difficult to diagnose problems sometimes.
* for using local builder, you needed to setup and authenticate with another
docker engine, which required SSH connectivity and port forwarding and it was
really not feasible for GitHub Actions where you cannot easily authenticate
between separate runners and make sure they are reachable from each other.
This PR implements different appreach - merging build images. Instead of
building them together, the images are built as ``digest-only`` images and
pushed to the registry and their metadata with digest is uploaded as artifacts.
Then a separate merge step downloads the metadata and creates merged manifest
where both images are referred to.
This allows to build each image separately on a separate hardware - way
faster in general (providing that we have an appropriate hypervisor capable
hardware for each platform that we can build the images on.
Part of #41935
(cherry picked from commit bc44a329e9e2f46eba591e084c443f94aa5dde08)
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
