potiuk commented on code in PR #50340: URL: https://github.com/apache/airflow/pull/50340#discussion_r2079665643
########## airflow-core/src/airflow/notifications/basenotifier.py: ########## @@ -20,3 +20,11 @@ from __future__ import annotations from airflow.sdk.bases.notifier import BaseNotifier as BaseNotifier +from airflow.utils.deprecation_tools import add_deprecated_classes Review Comment: But .... add_deprecated_classes is simpler and doe not require the module to be even created. The problem with importing things in the module requires you to create the module itself, which is kinda bad because it leaves traces behind (i.e. module) The nice thing about `add_deprecated_classes` and placing them in `__init__.py` is that the old module becomes invisible and not even visible when you auto-import stuff with IDE - simply IDE does not find neither module nor imported class any more so I'd say `add_deprecated_classes` is far superior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
