guan404ming commented on code in PR #50341:
URL: https://github.com/apache/airflow/pull/50341#discussion_r2080058194
##########
providers/google/src/airflow/providers/google/cloud/hooks/bigquery.py:
##########
@@ -306,6 +310,26 @@ def get_pandas_df(
return read_gbq(sql, project_id=project_id, dialect=dialect,
credentials=credentials, **kwargs)
+ async def _get_polars_df(self, sql, parameters=None, dialect=None,
**kwargs):
Review Comment:
I follow this [doc](https://docs.pola.rs/user-guide/io/bigquery/) to
implement this func. But what you say makes sense. I think I would try figure
out how to implement it in synchronous way. My initial thought is using the
same way to fetch df like pandas then use
[`polars.from_pandas`](https://docs.pola.rs/api/python/dev/reference/api/polars.from_pandas.html)
to transfer back to `polars` df. What do u think about this approach?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
