ashb commented on a change in pull request #6407: [AIRFLOW-5740] Fix Transient
failure in Slack test
URL: https://github.com/apache/airflow/pull/6407#discussion_r338526544
##########
File path: tests/contrib/hooks/test_slack_webhook_hook.py
##########
@@ -105,7 +105,7 @@ def test_build_slack_message(self):
message = hook._build_slack_message()
# Then
- self.assertEqual(self.expected_message, message)
+ self.assertCountEqual(self.expected_message, message)
Review comment:
Dicts are the same, it's just the order of keys (cos python 3.5 still has
random ordering) -- but `d1 == d2` is _meant_ to ignore that from everything we
can see and remember.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
