[
https://issues.apache.org/jira/browse/AIRFLOW-5742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16959266#comment-16959266
]
ASF GitHub Bot commented on AIRFLOW-5742:
-----------------------------------------
louisguitton commented on pull request #6424: [AIRFLOW-5742] Move Google Cloud
Vision to providers package
URL: https://github.com/apache/airflow/pull/6424
### Jira
- [ ] https://issues.apache.org/jira/browse/AIRFLOW-5742
### Description
- [ ] Moving the Google Cloud Vision Hook and Operator to the providers
package. Aligned with @nuclearpinguin at the Berlin Meetup tonight. I read and
followed his PRs https://github.com/apache/airflow/pull/6169 &
https://github.com/apache/airflow/pull/6170
Notes:
- I had to push with --no-verify due to `ERROR: The image needs rebuild for
SLIM_CI - it is outdated.` and the rebuild actually timing out ...
- Pre-commit hooks pass.
- `./scripts/ci/ci_docs.sh | grep -A5 WARNING` gives me the following errors
```
```
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
```sh
./breeze
run-tests tests.providers.google.cloud.hooks.test_vision
run-tests tests.providers.google.cloud.operators.test_vision
```
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Move Cloud Vision to providers package
> --------------------------------------
>
> Key: AIRFLOW-5742
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5742
> Project: Apache Airflow
> Issue Type: Improvement
> Components: gcp
> Affects Versions: 2.0.0
> Reporter: Tomasz Urbaszek
> Assignee: Louis Guitton
> Priority: Minor
>
> Move:
> airflow.gcp.operators.vision ->
> airflow.providers.google.cloud.operators.vision
> airflow.gcp.hooks.vision -> airflow.providers.google.cloud.hooks.vision
> and also relevant tests and example DAGs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
