[
https://issues.apache.org/jira/browse/AIRFLOW-5751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16959314#comment-16959314
]
ASF GitHub Bot commented on AIRFLOW-5751:
-----------------------------------------
dstandish commented on pull request #6426: [AIRFLOW-5751] add get_uri method to
Connection
URL: https://github.com/apache/airflow/pull/6426
* Add a convenience method `get_uri` on `Connection` object to generate the
URI for a connection.
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW-5751) issues and references
them in the PR title. For example, "\[AIRFLOW-5751\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-5751
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
Building URI for use in connection env var can be a nuisance. This is a
convenience method that will do it for you, given a connection object.
So if you have created one in UI, you could do
BaseHook.get_connection(conn_id).get_uri().
Or build using init params on `Connection` object and call `get_uri()`.
I added tests to verify that generated URIs, when parsed again, produce the
same connection object. For this I used the same URIs we were already testing.
And as part of this there was an efficiency in refactoring the existing
from_uri test.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> add get_uri method to Connection object
> ---------------------------------------
>
> Key: AIRFLOW-5751
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5751
> Project: Apache Airflow
> Issue Type: New Feature
> Components: core
> Affects Versions: 1.10.5
> Reporter: Daniel Standish
> Assignee: Daniel Standish
> Priority: Major
>
> Airflow can either use connections stored in database stored in URI form in
> environment variables.
> We can add a convenience method `get_uri` on `Connection` object to generate
> the URI for a connection.
> This can help users because sometimes it is a little tricky / not obvious how
> to generate the URI format.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
