jedcunningham commented on code in PR #50781:
URL: https://github.com/apache/airflow/pull/50781#discussion_r2096293022
##########
airflow-core/src/airflow/cli/commands/config_command.py:
##########
@@ -306,13 +305,11 @@ def message(self) -> str | None:
config=ConfigParameter("logging", "log_filename_template"),
was_removed=True,
remove_if_equals="{{ ti.dag_id }}/{{ ti.task_id }}/{{ ts }}/{{
try_number }}.log",
- breaking=True,
Review Comment:
We probably want to leave this one - it isn't handled in configuration.py
(yet?), but let's do these log_filename_template ones in a follow up.
##########
airflow-core/src/airflow/cli/commands/config_command.py:
##########
@@ -161,7 +161,6 @@ def message(self) -> str | None:
old_default="SequentialExecutor",
new_default="LocalExecutor",
was_removed=False,
- breaking=True,
Review Comment:
Yep! Not breaking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
