pierrejeambrun commented on code in PR #50839:
URL: https://github.com/apache/airflow/pull/50839#discussion_r2099867312
##########
providers/fab/src/airflow/providers/fab/www/app.py:
##########
@@ -56,7 +56,7 @@ def create_app(enable_plugins: bool):
from airflow.providers.fab.auth_manager.fab_auth_manager import
FabAuthManager
flask_app = Flask(__name__)
- flask_app.secret_key = conf.get("webserver", "SECRET_KEY")
+ flask_app.secret_key = conf.get("api", "SECRET_KEY")
Review Comment:
This is the solution we went for with the previous config move. (other PRs),
we discussed it with Jarek, Jed and you and we agreed that this was the easier
way, instead of writing compatibility code.
Discussed in:
- https://github.com/apache/airflow/pull/50208#issuecomment-2875590699
- https://github.com/apache/airflow/pull/50269#issuecomment-2875679246
- https://github.com/apache/airflow/issues/49896#issuecomment-2891759968
(Trying to find the last one with Jed)
Is there an issue with that approach ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
