Lee-W commented on code in PR #50864:
URL: https://github.com/apache/airflow/pull/50864#discussion_r2101476498
##########
providers/standard/src/airflow/providers/standard/sensors/time.py:
##########
@@ -100,32 +77,61 @@ def __init__(
self,
*,
target_time: datetime.time,
+ deferrable: bool = False,
start_from_trigger: bool = False,
- trigger_kwargs: dict[str, Any] | None = None,
Review Comment:
I think this should be kept for using `start_from_trigger` in dynamic task
mapping
##########
providers/standard/src/airflow/providers/standard/sensors/time.py:
##########
@@ -100,32 +77,61 @@ def __init__(
self,
*,
target_time: datetime.time,
+ deferrable: bool = False,
Review Comment:
I think it should be
```suggestion
deferrable: bool = conf.getboolean("operators",
"default_deferrable", fallback=False)
```
not sure why the pre-commit is not working, I'll take a look afterward
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
