sunank200 commented on code in PR #50922: URL: https://github.com/apache/airflow/pull/50922#discussion_r2102047453
########## airflow-core/src/airflow/migrations/versions/0072_3_1_0_modify_taskinstance_dag_version_fk.py: ########## @@ -0,0 +1,72 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +""" +Modify task_instance.dag_version_id FK on delete behavior to SET NULL. + +Revision ID: 1b2cd3e4f5a6 +Revises: 03e36c7f30aa +Create Date: 2025-05-21 00:00:00.000000 +""" + +from __future__ import annotations + +from alembic import op +from sqlalchemy_utils import UUIDType + +# revision identifiers, used by Alembic. +revision = "1b2cd3e4f5a6" +down_revision = "03e36c7f30aa" +branch_labels = None +depends_on = None +airflow_version = "3.1.0" + + +def upgrade(): + """Alter task_instance.dag_version_id to SET NULL on delete.""" + with op.batch_alter_table("task_instance", schema=None) as batch_op: + batch_op.drop_constraint(batch_op.f("task_instance_dag_version_id_fkey"), type_="foreignkey") Review Comment: I tried running this with sqlite backend. It worked fine. ########## airflow-core/src/airflow/migrations/versions/0072_3_1_0_modify_taskinstance_dag_version_fk.py: ########## @@ -0,0 +1,72 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +""" +Modify task_instance.dag_version_id FK on delete behavior to SET NULL. + +Revision ID: 1b2cd3e4f5a6 +Revises: 03e36c7f30aa +Create Date: 2025-05-21 00:00:00.000000 +""" + +from __future__ import annotations + +from alembic import op +from sqlalchemy_utils import UUIDType + +# revision identifiers, used by Alembic. +revision = "1b2cd3e4f5a6" +down_revision = "03e36c7f30aa" +branch_labels = None +depends_on = None +airflow_version = "3.1.0" + + +def upgrade(): + """Alter task_instance.dag_version_id to SET NULL on delete.""" + with op.batch_alter_table("task_instance", schema=None) as batch_op: + batch_op.drop_constraint(batch_op.f("task_instance_dag_version_id_fkey"), type_="foreignkey") + batch_op.alter_column( + "dag_version_id", + existing_type=UUIDType(binary=False), + nullable=True, + ) + batch_op.create_foreign_key( + batch_op.f("task_instance_dag_version_id_fkey"), + "dag_version", + ["dag_version_id"], + ["id"], + ondelete="SET NULL", + ) + + +def downgrade(): + """Revert task_instance.dag_version_id FK on delete back to CASCADE.""" + with op.batch_alter_table("task_instance", schema=None) as batch_op: + batch_op.drop_constraint(batch_op.f("task_instance_dag_version_id_fkey"), type_="foreignkey") Review Comment: I tried running this with sqlite backend. It worked fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
