JonnyIncognito commented on a change in pull request #6210: [AIRFLOW-5567] BaseAsyncOperator URL: https://github.com/apache/airflow/pull/6210#discussion_r339016148
########## File path: airflow/models/base_async_operator.py ########## @@ -0,0 +1,161 @@ +# -*- coding: utf-8 -*- +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +""" +Base Asynchronous Operator for kicking off a long running +operations and polling for completion with reschedule mode. +""" + +from abc import abstractmethod +from typing import Dict, List, Optional, Union + +from airflow.models import SkipMixin, TaskReschedule +from airflow.models.xcom import XCOM_EXTERNAL_RESOURCE_ID_KEY +from airflow.sensors.base_sensor_operator import BaseSensorOperator +from airflow.utils.decorators import apply_defaults + + Review comment: Back to the practical, can I propose: - New BaseOperator hooks are implemented - something like `execute_phase_start()` and `execute_phase_final()` - that by default simply `raise NotImplementedError()` as per current `execute()` implementation - New BaseOperator default `execute()` implementation that calls the two hooks in order. If the task was rescheduled, skip the first phase. I've seen code that detects this case in `BaseSensorOperator.execute()` ([link](https://github.com/apache/airflow/blob/master/airflow/sensors/base_sensor_operator.py#L104)). - Existing overrides of `BaseOperator.execute()` should then behave as-is, i.e. the phase hooks are simply never called. The current `BaseSensorOperator` implementation would continue to work, minimising the amount of work needed in this PR; it could later be reimplemented to use the new phased execution. - Any new operators implemented to combine an operation + sensor can override the new phase hooks, since they'd be multi-phase aware. Allowing only two phases simplifies the implementation for now given the immediate requirements, but could even be extended in future for any number of phases if we wanted to store the current/next phase as part of the task instance state. I can't think of a good practical need right now. What do you guys think, is this proposal (or something like it) workable? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
