bbovenzi commented on code in PR #50732:
URL: https://github.com/apache/airflow/pull/50732#discussion_r2103450781
##########
airflow-core/src/airflow/ui/src/pages/DagsList/DagsFilters.tsx:
##########
@@ -62,11 +65,22 @@ export const DagsFilters = () => {
const isRunning = state === "running";
const isFailed = state === "failed";
const isSuccess = state === "success";
+ const limit = 50;
+ const [pattern, setPattern] = useState<string>("");
+ const [offset, setOffset] = useState<number>(0);
+ const [tagsList, setTagsList] = useState<Array<string>>([]);
const { data } = useDagServiceGetDagTags({
+ limit,
+ offset,
orderBy: "name",
+ tagNamePattern: pattern,
});
+ useEffect(() => {
+ setTagsList((tags) => [...tags, ...(data?.tags ?? [])]);
+ }, [data, setTagsList]);
Review Comment:
Why do we have this useEffect and tasgList useState? `data.tags` should
already be updating
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
