tirkarthi commented on code in PR #50885:
URL: https://github.com/apache/airflow/pull/50885#discussion_r2104619532
##########
airflow-core/src/airflow/ui/src/components/Clear/Run/ClearRunButton.tsx:
##########
@@ -17,33 +17,46 @@
* under the License.
*/
import { Box, useDisclosure } from "@chakra-ui/react";
+import { useHotkeys } from "react-hotkeys-hook";
import { CgRedo } from "react-icons/cg";
import type { DAGRunResponse } from "openapi/requests/types.gen";
+import { Tooltip } from "src/components/ui";
import ActionButton from "src/components/ui/ActionButton";
import ClearRunDialog from "./ClearRunDialog";
type Props = {
readonly dagRun: DAGRunResponse;
+ readonly hasHotKey?: boolean;
readonly withText?: boolean;
};
-const ClearRunButton = ({ dagRun, withText = true }: Props) => {
+const ClearRunButton = ({ dagRun, hasHotKey = false, withText = true }: Props)
=> {
Review Comment:
Thanks for the review. Since this is a boolean perhaps name it as
`isHotkeyEnabled` or `hasHotkeyEnabled` as per convention? I haven't tried the
lint aspect but named it `hasHotkey` based on this convention.
https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/boolean-prop-naming.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
