geraj1010 commented on code in PR #48466:
URL: https://github.com/apache/airflow/pull/48466#discussion_r2106383237


##########
providers/dbt/cloud/src/airflow/providers/dbt/cloud/operators/dbt.py:
##########
@@ -239,7 +244,13 @@ def execute(self, context: Context):
                     DbtCloudJobRunStatus.CANCELLED.value,
                     DbtCloudJobRunStatus.ERROR.value,
                 ):
-                    raise DbtCloudJobRunException(f"Job run {self.run_id} has 
failed or has been cancelled.")
+
+                    raise DbtCloudJobRunDetailsException(
+                        self.account_id,
+                        self.run_id,
+                        message=f"Job run {self.run_id} has failed or has been 
cancelled.",

Review Comment:
   That was the original message, and I think it's because this only gets 
raised if the status is `ERROR` or `CANCELLED`. However, I do think it would be 
cleaner to include `job_run_status` just in case there are additional statuses 
that get included in this block. Otherwise, we would have to update the message 
again to include any new statues.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to