pierrejeambrun commented on code in PR #49164:
URL: https://github.com/apache/airflow/pull/49164#discussion_r2107375394
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/task_instances.py:
##########
@@ -738,7 +761,13 @@ def _patch_ti_validate_request(
map_index: int | None = -1,
update_mask: list[str] | None = Query(None),
) -> tuple[DAG, list[TI], dict]:
- dag = dag_bag.get_dag(dag_id)
+ try:
+ dag = dag_bag.get_dag(dag_id)
+ except DeserializationError as e:
+ raise HTTPException(
+ status_code=status.HTTP_400_BAD_REQUEST,
+ detail=f"An error occurred while trying to deserialize DAG
'{dag_id}': {e}",
+ )
Review Comment:
IF you do that you'll also only have to test the exception handler, and not
all the routes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
