willianzilli commented on issue #38195: URL: https://github.com/apache/airflow/issues/38195#issuecomment-2910845349
this PR [Fix overwrite get_uri for Oracle #48734](https://github.com/apache/airflow/pull/48734) dont work for get_sqlalchemy_conn because oracledb is supported on SqlAlchemy major 2, which cause error `sqlalchemy.exc.NoSuchModuleError: Can't load plugin: sqlalchemy.dialects:oracle.oracledb`. Force "+oracledb" in line 465 broke the code `uri = f"oracle+oracledb://{login}:{password}@{host}:{port}"` Also, [test_oracle.py](https://github.com/apache/airflow/blob/providers-oracle/4.1.0/providers/oracle/tests/unit/oracle/hooks/test_oracle.py) file dont check get_sqlalchemy_conn method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
