uranusjr commented on code in PR #50117:
URL: https://github.com/apache/airflow/pull/50117#discussion_r2108403069
##########
task-sdk/src/airflow/sdk/api/client.py:
##########
@@ -470,7 +471,27 @@ def get_sequence_item(
},
)
raise
- return XComResponse.model_validate_json(resp.read())
+ return XComSequenceIndexResponse.model_validate_json(resp.read())
+
+ def get_sequence_slice(
+ self,
+ dag_id: str,
+ run_id: str,
+ task_id: str,
+ key: str,
+ start: int | None,
+ stop: int | None,
+ step: int | None,
Review Comment:
The problem is FastAPI does not handle None well in the query string.
`{"start": None}` would just result in the backend receiving `start=None` and
blowing up because it’s parsed as a literal string `"None"`. Providing defaults
would not help here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
