guan404ming commented on code in PR #50792:
URL: https://github.com/apache/airflow/pull/50792#discussion_r2109052004
##########
airflow-core/src/airflow/config_templates/config.yml:
##########
@@ -2420,7 +2420,7 @@ dag_processor:
description: |
How long before timing out a DagFileProcessor, which processes a dag
file
version_added: ~
- type: string
+ type: integer
Review Comment:
I believe the default values in the config are all stored as strings.
However, some of them like `dag_file_processor_timeout` are later cast to other
types. So I was thinking it might be helpful to somehow indicate the actual
expected type to users, rather than just relying on the fact that the value is
passed as a string. Otherwise, users might try inputs like "long long time" or
"1hr", thinking those are acceptable. Also, I’m totally open to other ideas if
there’s a better way to handle this~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
